[GitHub] [incubator-nuttx] zhaoxiu-zeng commented on a change in pull request #5171: semphore: release all semphores' holder that the task held when exit

[GitBox]

zhaoxiu-zeng commented on a change in pull request #5171:
URL: https://github.com/apache/incubator-nuttx/pull/5171#discussion_r782747575



##########
File path: sched/semaphore/sem_holder.c
##########
@@ -263,23 +276,16 @@ static int nxsem_foreachholder(FAR sem_t *sem, 
holderhandler_t handler,
 
       next = pholder->flink;

Review comment:
       No, because the holder may be freed in the handler callback, so we must 
preserve pointer to the next holder before calling handler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org