xiaoxiang781216 commented on a change in pull request #5230:
URL: https://github.com/apache/incubator-nuttx/pull/5230#discussion_r785409884
##########
File path: drivers/timers/rpmsg_rtc.c
##########
@@ -590,38 +590,41 @@ static int rpmsg_rtc_server_ept_cb(FAR struct
rpmsg_endpoint *ept,
case RPMSG_RTC_GET:
{
FAR struct rpmsg_rtc_get_s *msg = data;
- struct timespec ts;
+ struct rtc_time rtctime;
- header->result = clock_gettime(CLOCK_REALTIME, &ts);
- msg->sec = ts.tv_sec;
- msg->nsec = ts.tv_nsec;
+ header->result = server->lower->ops->rdtime(server->lower,
+ &rtctime);
+ msg->sec = timegm((FAR struct tm *)&rtctime);
+ msg->nsec = rtctime.tm_nsec;
return rpmsg_send(ept, msg, sizeof(*msg));
}
case RPMSG_RTC_SET:
{
FAR struct rpmsg_rtc_set_s *msg = data;
- struct timespec ts;
+ struct rtc_time rtctime;
+ time_t time = msg->sec;
- ts.tv_sec = msg->sec;
- ts.tv_nsec = msg->nsec;
- header->result = clock_settime(CLOCK_REALTIME, &ts);
+ gmtime_r(&time, (FAR struct tm *)rtctime);
+ rtctime.tm_nsec = msg->nsec;
+ header->result = server->lower->ops->settime(server->lower,
+ &rtctime);
return rpmsg_send(ept, msg, sizeof(*msg));
}
#ifdef CONFIG_RTC_ALARM
case RPMSG_RTC_ALARM_SET:
{
- FAR struct rpmsg_rtc_session_s *session = container_of(ept,
- struct rpmsg_rtc_session_s, ept);
+ FAR struct rpmsg_rtc_client_s *client = container_of(ept,
+ struct rpmsg_rtc_client_s, ept);
FAR struct rpmsg_rtc_alarm_set_s *msg = data;
FAR struct rpmsg_rtc_server_s *server = priv;
time_t time = msg->sec;
struct lower_setalarm_s alarminfo =
{
.id = msg->id,
.cb = rpmsg_rtc_server_alarm_cb,
- .priv = session
+ .priv = client
Review comment:
Done.
##########
File path: drivers/timers/rpmsg_rtc.c
##########
@@ -653,31 +656,31 @@ static void rpmsg_rtc_server_ns_bind(FAR struct
rpmsg_device *rdev,
uint32_t dest)
{
FAR struct rpmsg_rtc_server_s *server = priv;
- FAR struct rpmsg_rtc_session_s *session;
+ FAR struct rpmsg_rtc_client_s *client;
if (strcmp(name, RPMSG_RTC_EPT_NAME))
{
return;
}
- session = kmm_zalloc(sizeof(*session));
- if (!session)
+ client = kmm_zalloc(sizeof(*client));
+ if (!client)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
