pkarashchenko commented on a change in pull request #968:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/968#discussion_r785450250
##########
File path: examples/nxterm/nxterm_internal.h
##########
@@ -92,8 +92,8 @@
# define CONFIG_EXAMPLES_NXTERM_BPP 8
# elif !defined(CONFIG_NX_DISABLE_16BPP)
# define CONFIG_EXAMPLES_NXTERM_BPP 16
-//#elif !defined(CONFIG_NX_DISABLE_24BPP)
-//# define CONFIG_NXTERM_BPP 24
+#elif !defined(CONFIG_NX_DISABLE_24BPP)
Review comment:
```suggestion
# elif !defined(CONFIG_NX_DISABLE_24BPP)
```
I didn't make this change because was not sure why the `CONFIG_NXTERM_BPP
24` case was comment out.
##########
File path: examples/nxtext/nxtext_internal.h
##########
@@ -69,8 +69,8 @@
# define CONFIG_EXAMPLES_NXTEXT_BPP 8
# elif !defined(CONFIG_NX_DISABLE_16BPP)
# define CONFIG_EXAMPLES_NXTEXT_BPP 16
-//#elif !defined(CONFIG_NX_DISABLE_24BPP)
-//# define CONFIG_NXTERM_BPP 24
+#elif !defined(CONFIG_NX_DISABLE_24BPP)
Review comment:
```suggestion
# elif !defined(CONFIG_NX_DISABLE_24BPP)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
