a-lunev commented on a change in pull request #5242:
URL: https://github.com/apache/incubator-nuttx/pull/5242#discussion_r786005125
##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -320,41 +298,38 @@ static uint16_t sendfile_eventhandler(FAR struct
net_driver_s *dev,
tcp_setsequence(conn->sndseq, seqno);
+ /* Notify the device driver of the availability of TX data */
+
+ sendfile_txnotify(psock, conn);
+
/* Update the amount of data sent (but not necessarily ACKed) */
pstate->snd_sent += sndlen;
ninfo("pid: %d SEND: acked=%" PRId32 " sent=%zd flen=%zu\n",
getpid(),
pstate->snd_acked, pstate->snd_sent, pstate->snd_flen);
}
- else
- {
- nwarn("WARNING: Window full, wait for ack\n");
- goto wait;
- }
}
- if (pstate->snd_sent >= pstate->snd_flen
Review comment:
I have just forced-pushed the changes concerning your other remarks. So
the check for outstanding acks is moved from line 186 to 251 in the changed
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
