xiaoxiang781216 commented on a change in pull request #5247: URL: https://github.com/apache/incubator-nuttx/pull/5247#discussion_r786217985
########## File path: arch/risc-v/src/common/riscv_exception_common.S ########## @@ -49,7 +49,9 @@ exception_common: addi sp, sp, -XCPTCONTEXT_SIZE REGSTORE x1, REG_X1(sp) /* ra */ +#ifdef RISCV_SAVE_GP Review comment: where define this macro? ########## File path: arch/risc-v/src/common/riscv_exception_common.S ########## @@ -178,16 +181,8 @@ exception_common: .type g_intstackalloc, object .type g_intstacktop, object g_intstackalloc: -#ifndef CONFIG_SMP - .skip ((CONFIG_ARCH_INTERRUPTSTACK + 8) & ~15) -#else - .skip (((CONFIG_ARCH_INTERRUPTSTACK * CONFIG_SMP_NCPUS) + 8) & ~15) Review comment: why not use CONFIG_SMP_NCPUS? ########## File path: arch/risc-v/src/mpfs/Kconfig ########## @@ -46,6 +46,9 @@ config MPFS_BOOTLOADER ---help--- This NuttX image is used as a bootloader, which will boot only on one hart, putting the others in WFI +config N_IRQ_STACKS Review comment: it's wrong to define N_IRQ_STACKS in here and sched/Kconfig? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org