yamt commented on pull request #4487: URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-1017175259
> > > arch/sim: Don't add -lc++abi to STDLIBS > > > > > > it's probably ok, but i'm not sure if i understand the motivation. > > We use libcxx library from: https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxx.defs It's also reasonable to use libcxxabi from: https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxxabi.defs to keep both in sync. ok. > > > > boards/sim: Remove the check CONFIG_LIBCXX before build up_macho_init.c > > > > > > it can cause assertion failure here for non-C++ configurations. > > https://github.com/apache/incubator-nuttx/blob/ea6141e01b1e2953cbdb36805b7eeeb877bdb673/arch/sim/src/sim/up_macho_init.c#L63 > > The assert is wrong, why assume C++ program must have global variables with constructor? maybe you are right. but even if the assertion is fixed, i still feel uneasy to enable this hack unconditionally. > > > maybe check HAVE_CXXINITIALIZE instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
