no1wudi commented on a change in pull request #5291:
URL: https://github.com/apache/incubator-nuttx/pull/5291#discussion_r788781658
##########
File path: arch/risc-v/src/qemu-rv/qemu_rv_irq.c
##########
@@ -108,17 +108,17 @@ void up_disable_irq(int irq)
int extirq;
uint32_t oldstat;
- if (irq == QEMU_RV_IRQ_MTIMER)
+ if (irq == RISCV_IRQ_MTIMER)
{
/* Read mstatus & clear machine timer interrupt enable in mie */
asm volatile("csrrc %0, mie, %1"
: "=r"(oldstat)
: "r"(MIE_MTIE));
}
- else if (irq > QEMU_RV_IRQ_MEXT)
+ else if (irq > RISCV_IRQ_MEXT)
Review comment:
No need for that since `RISCV_IRQ_MEXT` would not be enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]