fjpanag commented on a change in pull request #5295:
URL: https://github.com/apache/incubator-nuttx/pull/5295#discussion_r790646608
##########
File path: arch/sim/src/sim/up_uart.c
##########
@@ -31,12 +31,16 @@
#include "up_internal.h"
-#if defined(USE_DEVCONSOLE) || CONFIG_SIM_UART_NUMBER > 0
+#if defined(USE_DEVCONSOLE) || defined(CONFIG_SIM_UART)
/****************************************************************************
* Pre-processor Definitions
****************************************************************************/
-#define BUFSIZE 256
+#ifdef CONFIG_SIM_UART_BUFFER_SIZE
Review comment:
@pkarashchenko Sorry, I didn't understand.
What will be the benefit of this?
When needed, `CONFIG_SIM_UART_BUFFER_SIZE` is automatically defined by
Kconfig, why we need this check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
