xiaoxiang781216 commented on a change in pull request #5408:
URL: https://github.com/apache/incubator-nuttx/pull/5408#discussion_r799292494
##########
File path: drivers/syslog/syslog_device.c
##########
@@ -491,18 +511,29 @@ static ssize_t syslog_dev_write(FAR struct
syslog_channel_s *channel,
{
nwritten = file_write(&syslog_dev->sl_file,
g_syscrlf, 2);
+
+ /* Synchronize the file when each CR-LF is encountered
+ * (i.e., implements line buffering always).
+ */
+
+#ifndef CONFIG_DISABLE_MOUNTPOINT
Review comment:
can we remove #ifdef and let syslog_dev_flush do the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
