xiaoxiang781216 commented on a change in pull request #5423:
URL: https://github.com/apache/incubator-nuttx/pull/5423#discussion_r800103690
##########
File path: drivers/pipes/Kconfig
##########
@@ -14,8 +14,7 @@ if PIPES
config DEV_PIPE_MAXSIZE
int "Maximum pipe/FIFO size"
- default 1024 if !DEFAULT_SMALL
- default 256 if DEFAULT_SMALL
+ default 65535
Review comment:
If DEV_PIPE_MAXSIZE is just used for DEBUGASSERT, I prefer to remove it
directly. But, DEV_PIPE_MAXSIZE is also used to map pipe_ndx_t to
uint8_t/uint16_t/uint32_t. So, it have to keep it if we want to save several
bytes per pipe. The default value is changed to 65535(the max of uint16_t), so
we can safely ignore this config in most case. it's much better than the old
default value(256/1024).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
