xiaoxiang781216 commented on a change in pull request #5417:
URL: https://github.com/apache/incubator-nuttx/pull/5417#discussion_r800289759
##########
File path: include/pthread.h
##########
@@ -197,7 +197,7 @@
#define pthread_setname_np(thread, name) \
prctl((int)PR_SET_NAME_EXT, (char*)name, (int)thread)
-#define pthread_getname_np(thread, name) \
+#define pthread_getname_np(thread, name, len) \
Review comment:
Yes, you are right, but PR_GET_NAME defined by Linux in the same way:
https://man7.org/linux/man-pages/man2/prctl.2.html
```
PR_GET_NAME (since Linux 2.6.11)
Return the name of the calling thread, in the buffer
pointed to by (char *) arg2. The buffer should allow
space for up to 16 bytes; the returned string will be
null-terminated.
```
So, it's better to keep the prototype as it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
