a-lunev commented on pull request #5434:
URL: https://github.com/apache/incubator-nuttx/pull/5434#issuecomment-1031880176
> > @anchao if it is possible, please split the patch into two separate ones.
>
> @a-lunev
>
> These 2 issues depends on the "common connect prologue" change. I tried to
separate the related commit, but which could not pass the CI check at the same
time, the commit before submitted to the mainline, each protocols needs to pass
the verification from tester, therefore, the relevant commit of this PR is
split in detail
I have preliminary looked through the 24 commits. The following two commits
seem independent of PR #5434:
commit 871650b558781434fec0430d21df913214595db8
net/socket: remove unused _SF_INITD
commit c8dcb02727b0b06746c026ba930e7167eb012abd
net/socket: remove unused _SF_CLOSED
If so, let's move these two commits to separate PRs and consider / merge
them first. It is important to decompose the complexity of the huge patch to
reduce risk of breaking / missing something. And it will be easier to catch /
isolate potential issues if they are merged not at once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
