xiaoxiang781216 commented on a change in pull request #5363:
URL: https://github.com/apache/incubator-nuttx/pull/5363#discussion_r801379915



##########
File path: arch/arm/src/phy62xx/uart.c
##########
@@ -878,10 +887,21 @@ static int pplus_uart_receive(struct uart_dev_s *dev, 
unsigned int *status)
 {
   uart_Ctx_t *priv = (uart_Ctx_t *)dev->priv;
   uint32_t data;
+  static uint8_t fifo_buf_store[UART_RX_BUFFER_SIZE];
+  static int buf_head;
+  static int buf_tail;
+  /* Put fifo data into loopback buffer */
+  for(int i=0;i<fifo_len_store;i++)

Review comment:
       you need fix the problem in this patch. Each patch should be in the good 
state before it get merge.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to