xiaoxiang781216 commented on a change in pull request #5486:
URL: https://github.com/apache/incubator-nuttx/pull/5486#discussion_r805520014
##########
File path: arch/sim/src/Makefile
##########
@@ -285,14 +285,14 @@ nuttx-names.dat: nuttx-names.in
nuttx$(EXEEXT): libarch$(LIBEXT) board/libboard$(LIBEXT) $(HEADOBJ)
$(LINKOBJS) $(HOSTOBJS) nuttx-names.dat
$(Q) echo "LD: nuttx$(EXEEXT)"
$(Q) $(LD) -r $(LDLINKFLAGS) $(RELPATHS) $(EXTRA_LIBPATHS) -o nuttx.rel
$(REQUIREDOBJS) $(LDSTARTGROUP) $(RELLIBS) $(EXTRA_LIBS) $(LDENDGROUP)
-ifeq ("$(shell $(CC) --version | grep clang)","")
- # none clang based native compilers need opjcopy to build simulation
+ifneq ($(CONFIG_HOST_MACOS),y)
Review comment:
Why the separate change? The previous change assume the rename and
init_array is specific to gcc, but you think both is specific to OS. Could you
fix the problem in one patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
