pkarashchenko commented on pull request #5519: URL: https://github.com/apache/incubator-nuttx/pull/5519#issuecomment-1045150385
> I recognize that by having the various NULL checks, some compilers may issue warnings about impossible code paths, etc. However I feel it is safer to have the NULL checks. One idea could be to make '-Werror=nonnull-compare' and '-Werror=format-truncation' dependent on (yet another) Kconfig and make the compiler warnings and the NULL pointer checks mutually exclusive. So either you have compiler warnings or NULL checks, but not both or neither. My 2 cents. :-) Do you propose leave error checks and suppress compiler warnings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
