pkarashchenko commented on a change in pull request #5559:
URL: https://github.com/apache/incubator-nuttx/pull/5559#discussion_r810632116
##########
File path: boards/sim/sim/sim/scripts/Make.defs
##########
@@ -71,17 +74,12 @@ ARCHWARNINGSXX = -Wall -Wshadow -Wundef
# Add -fvisibility=hidden
# Because we don't want export nuttx's symbols to share libraries
-ARCHCPUFLAGS += -fvisibility=hidden
-ARCHCPUFLAGSXX += -fvisibility=hidden
-
-# Add -fno-common because macOS "ld -r" doesn't seem to pick objects
-# for common symbols.
-ARCHCPUFLAGS += -fno-common
-ARCHCPUFLAGSXX += -fno-common
+ARCHCFLAGS += -fvisibility=hidden
Review comment:
Maybe we can move this above the same as `-fno-common` was moved?
Or keep both `-fno-common` and `-fvisibility=hidden` split
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
