pkarashchenko commented on a change in pull request #5557:
URL: https://github.com/apache/incubator-nuttx/pull/5557#discussion_r810638224
##########
File path: arch/ceva/src/Makefile
##########
@@ -41,22 +41,13 @@ ifeq ($(CONFIG_WINDOWS_NATIVE),y)
CFLAGS += -I$(TOPDIR)\sched
else
ARCH_SRCDIR = $(TOPDIR)/arch/$(CONFIG_ARCH)/src
-ifeq ($(WINTOOL),y)
- NUTTX = "${shell cygpath -w $(OUTDIR)/nuttx$(EXEEXT)}"
- CFLAGS += -I "${shell cygpath -w $(ARCH_SRCDIR)/chip}"
- CFLAGS += -I "${shell cygpath -w $(ARCH_SRCDIR)/common}"
- CFLAGS += -I "${shell cygpath -w $(ARCH_SRCDIR)/$(ARCH_SUBDIR)}"
- CFLAGS += -I "${shell cygpath -w $(ARCH_SRCDIR)/$(CONFIG_ARCH_CHIP)}"
- CFLAGS += -I "${shell cygpath -w $(TOPDIR)/sched}"
- LDSCRIPT := ${shell cygpath -m $(LDSCRIPT)}
-else
- NUTTX = "$(OUTDIR)/nuttx$(EXEEXT)"
- CFLAGS += -I$(ARCH_SRCDIR)/chip
- CFLAGS += -I$(ARCH_SRCDIR)/common
- CFLAGS += -I$(ARCH_SRCDIR)/$(ARCH_SUBDIR)
- CFLAGS += -I$(ARCH_SRCDIR)/$(CONFIG_ARCH_CHIP)
- CFLAGS += -I$(TOPDIR)/sched
-endif
+ NUTTX = $(call CONVERT_PATH,$(OUTDIR)/nuttx$(EXEEXT))
+ CFLAGS += -I $(call CONVERT_PATH,$(ARCH_SRCDIR)/chip)
+ CFLAGS += -I $(call CONVERT_PATH,$(ARCH_SRCDIR)/common)
+ CFLAGS += -I $(call CONVERT_PATH,$(ARCH_SRCDIR)/$(ARCH_SUBDIR))
+ CFLAGS += -I $(call CONVERT_PATH,$(ARCH_SRCDIR)/$(CONFIG_ARCH_CHIP))
+ CFLAGS += -I $(call CONVERT_PATH,$(TOPDIR)/sched)
+ LDSCRIPT := $(call CONVERT_PATH,$(LDSCRIPT))
Review comment:
Should this be
```suggestion
ifeq ($(WINTOOL),y)
LDSCRIPT := $(call CONVERT_PATH,$(LDSCRIPT))
endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
