xiaoxiang781216 commented on a change in pull request #5553:
URL: https://github.com/apache/incubator-nuttx/pull/5553#discussion_r810642893
##########
File path: boards/xtensa/esp32s2/esp32s2-saola-1/scripts/Make.defs
##########
@@ -46,16 +46,16 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -mlongcalls
-ARCHCXXFLAGS = $(ARCHCFLAGS) -fno-exceptions -fcheck-new -fno-rtti
+ARCHCFLAGS = -fno-common -fno-builtin -ffunction-sections -fdata-sections
-mlongcalls
+ARCHCXXFLAGS = -fno-common $(ARCHCFLAGS) -fno-exceptions -fcheck-new -fno-rtti
ARCHWARNINGS = -Wall -Wstrict-prototypes -Wshadow -Wundef
ARCHWARNINGSXX = -Wall -Wshadow -Wundef
ARCHPICFLAGS = -fpic
# if SPIRAM/PSRAM is used then we need to include a workaround
ifeq ($(CONFIG_ESP32S2_SPIRAM),y)
- ARCHCFLAGS += -mfix-esp32s2-psram-cache-issue
+ ARCHCFLAGS += -fno-common -mfix-esp32s2-psram-cache-issue
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
