pkarashchenko commented on a change in pull request #5498: URL: https://github.com/apache/incubator-nuttx/pull/5498#discussion_r810681107
########## File path: sched/task/task_tls_alloc.c ########## @@ -0,0 +1,113 @@ +/**************************************************************************** + * sched/task/task_tls_alloc.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <sys/types.h> +#include <unistd.h> +#include <sched.h> +#include <errno.h> + +#include <nuttx/tls.h> +#include <nuttx/semaphore.h> + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +#if CONFIG_TLS_TASK_NELEM > 0 + +static tls_ndxset_t g_tlsset = 0; Review comment: We either need to add ``` #if CONFIG_TLS_TASK_NELEM > 0 # if CONFIG_TLS_TASK_NELEM > 64 # error Too many task TLS elements # elif CONFIG_TLS_TASK_NELEM > 32 typedef uint64_t tls_task_ndxset_t; # elif CONFIG_TLS_TASK_NELEM > 16 typedef uint32_t tls_task_ndxset_t; # elif CONFIG_TLS_TASK_NELEM > 8 typedef uint16_t tls_task_ndxset_t; # else typedef uint8_t tls_task_ndxset_t; # endif ``` and use `tls_task_ndxset_t` here or just use `uint64_t` for simplicity. Since this is globally allocated, then we can go with `uint64_t`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
