Ouss4 commented on a change in pull request #5336:
URL: https://github.com/apache/incubator-nuttx/pull/5336#discussion_r814053542
##########
File path: arch/xtensa/src/common/xtensa_context.S
##########
@@ -541,55 +544,13 @@ _xtensa_context_restore:
xtensa_context_restore:
ENTRY(16)
-#ifndef __XTENSA_CALL0_ABI__
- /* Force a spill of the live registers of the thread that has been
- * suspended.
- *
- * _xtensa_window_spill return state:
- * a2, a3: clobbered
- * a4,a5,a8,a9,a12,a13: preserved
- * a6,a7,a10,a11,a14,a15 clobbered if they were part of window(s)
- * to be spilled, otherwise they are the same as on entry
- * loop registers: Preserved
- * SAR: clobbered
- *
- * We need to preserve only a2 for _xtensa_context_restore
- */
+ mov a3, a2
+ movi a2, SYS_restore_context
+ movi a4, XCHAL_SWINT_CALL
+ wsr a4, intset
+ memw
Review comment:
do we need `memw` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
