spiriou commented on pull request #1038: URL: https://github.com/apache/incubator-nuttx-apps/pull/1038#issuecomment-1057476851
> > > @spiriou could you take a look? > > > > > > LGTM. > > Now may be the right time to remove config `stm32f103-minimum:adb` as new libuv and adb won't fit in anymore. > > could you give more info why they don't fit together? I would expect the change in libuv and microadb should work with preexisting config. libuv is optimized for performance at the cost of flash and ram usage. It's fine for most usecases. stm32f103-minimum board has 20KB of RAM and 64kB of flash. adb config builds nuttx, usb stack with adb driver, libuv and adb server. It did barely fit with the reduced footprint port of libuv so it may not work anymore now. I would just drop this config as it's useless anyway. I think the new libuv integration is better for long term purpose as it reduces complexity and makes support and maintenance easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
