xiaoxiang781216 commented on a change in pull request #5662:
URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r818348262
##########
File path: arch/arm/src/armv7-r/Toolchain.defs
##########
@@ -67,6 +67,32 @@ else
MAXOPTIMIZATION += -fomit-frame-pointer
endif
+ARCHCPUFLAGS = -march=armv7-r
Review comment:
don't need if we specify -mcpu=xxx?
##########
File path: arch/arm/src/armv7-r/Toolchain.defs
##########
@@ -67,6 +67,32 @@ else
MAXOPTIMIZATION += -fomit-frame-pointer
endif
+ARCHCPUFLAGS = -march=armv7-r
+
+ifeq ($(CONFIG_ARCH_FPU),y)
+ ARCHCPUFLAGS += -mfloat-abi=hard -mfpu=vfpv3-d16
+else
+ ARCHCPUFLAGS += -mfloat-abi=soft
+endif
+
+endif
Review comment:
which 'if' match this 'endif'
##########
File path: arch/arm/src/armv7-r/Toolchain.defs
##########
@@ -67,6 +67,32 @@ else
MAXOPTIMIZATION += -fomit-frame-pointer
endif
+ARCHCPUFLAGS = -march=armv7-r
+
+ifeq ($(CONFIG_ARCH_FPU),y)
+ ARCHCPUFLAGS += -mfloat-abi=hard -mfpu=vfpv3-d16
+else
+ ARCHCPUFLAGS += -mfloat-abi=soft
+endif
+
+endif
+
+ifeq ($(CONFIG_ENDIAN_BIG),y)
+ ARCHCPUFLAGS += -mbig-endian
+endif
+
+ifeq ($(CONFIG_ARCH_CORTEXR4),y)
+ ifeq ($(CONFIG_ARCH_FPU),y)
+ ARCHCPUFLAGS += -mcpu=cortex-r4f
Review comment:
don't f suffix since "ARCHCPUFLAGS += -mfloat-abi=hard -mfpu=vfpv3-d16"
at line 73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
