pkarashchenko commented on a change in pull request #5662:
URL: https://github.com/apache/incubator-nuttx/pull/5662#discussion_r818518400



##########
File path: arch/arm/Kconfig
##########
@@ -889,18 +889,31 @@ config ARM_HAVE_WFE_SEV
 
 config ARM_HAVE_FPU_D32
        bool
-       select ARCH_HAVE_FPU
        default n
+       depends on ARCH_DPFPU
        ---help---
-               FPU implemented in the VFPv3-D32 format that supports
+               FPU implemented in the VFPv[3|4]-D32 format that supports
                32 double-precision floating-point registers.
 
 config ARM_HAVE_NEON
        bool
        default n
+       depends ARM_HAVE_FPU_D32
        ---help---
                Decide whether support NEON instruction
 
+config ARM_FPU_ABI_SOFT
+       bool "Soft Float ABI"
+       default n
+       depends on ARCH_HAVE_FPU
+       ---help---
+               Pass float value via integer register (-mfloat-abi=softfp) 
+
+config ARM_NEON
+       bool "Advanced SIMD (NEON) Extension"
+       default n

Review comment:
       I think this should be defaulted to `y` or better to `default 
ARM_HAVE_NEON`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to