pkarashchenko commented on pull request #929: URL: https://github.com/apache/incubator-nuttx-apps/pull/929#issuecomment-1059271340
> > I still need a day to think about this change. In general I support a motivation of moving things to `apps/examples` and group related functionality in `mcuboot` folder. I'm writing this because when I'm looking into `lvgldemo` example that seems natural to me and I think that possibly examples for other libraries (third party code) should follow the similar way. I will examine other use cases as well and get back to this change with the update. > > `lvgldemo` is a recipe for building the former `lv_demos` project, which was a dedicated repository just for the LVGL demo apps. I understand that as a justification to live in the `examples` folder. But, after LVGL 8.2 release `lv_demos` has been integrated to the `lvgl` project, making the other repository obsolete: https://github.com/lvgl/lv_demos https://github.com/lvgl/lvgl/tree/master/demos > > Once LVGL gets updated to the latest release in `nuttx-apps`, I believe `examples/lvgldemo` should be deleted and the applicable options should appear alongside `graphics/lvgl`. Yes. I understand that. But there is a difference with MCUboot case. The MCUboot examples that are a part of this PR are not provided by MCUboot and are an example on how to use third party code like `examples/mqttc` is an example on top of `NETUTILS_MQTTC`. If those examples reside inside the MCUboot repository than it would be logically to keep integration file inside the `boot/mcuboot` folder. I think that we should go in the next way: 1. Move MCUboot examples to `examples` folder. 2. Rename `boot` to `bootutils`. I also just noticed that there is some inconsistency with `modbus` that is located not inside the `netutils`. That is also something for me to think about. So to summarize: I'm fine to continue with this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
