pkarashchenko commented on a change in pull request #1044:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1044#discussion_r820229139
##########
File path: system/termcurses/tcurses_vt100.c
##########
@@ -782,7 +782,7 @@ static int tcurses_vt100_move(FAR struct termcurses_s *dev,
int type,
FAR struct tcurses_vt100_s *priv;
int ret = -ENOSYS;
int fd;
- char str[16];
+ char str[32];
Review comment:
should we change `sprintf` to `snprintf`?
##########
File path: system/nxplayer/nxplayer.c
##########
@@ -1778,7 +1778,7 @@ static int nxplayer_playinternal(FAR struct nxplayer_s
*pplayer,
struct audio_caps_desc_s cap_desc;
struct ap_buffer_info_s buf_info;
#ifdef CONFIG_NXPLAYER_INCLUDE_MEDIADIR
- char path[128];
+ char path[256];
Review comment:
```suggestion
char path[PATH_MAX];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
