xiaoxiang781216 commented on a change in pull request #5695:
URL: https://github.com/apache/incubator-nuttx/pull/5695#discussion_r822240815
##########
File path: arch/risc-v/include/setjmp.h
##########
@@ -25,13 +25,25 @@
* Included Files
****************************************************************************/
+#include <nuttx/config.h>
+#include <nuttx/compiler.h>
+
/****************************************************************************
* Public Types
****************************************************************************/
struct setjmp_buf_s
{
long regs[14];
+
+ /* Float callee register : fs0-fs11 */
+#ifdef CONFIG_ARCH_DPFPU
Review comment:
should we move CONFIG_ARCH_DPFPU to first?
##########
File path: arch/risc-v/include/setjmp.h
##########
@@ -25,13 +25,25 @@
* Included Files
****************************************************************************/
+#include <nuttx/config.h>
+#include <nuttx/compiler.h>
+
/****************************************************************************
* Public Types
****************************************************************************/
struct setjmp_buf_s
{
long regs[14];
Review comment:
change long to uintptr_t like xcpt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
