hartmannathan commented on pull request #5151: URL: https://github.com/apache/incubator-nuttx/pull/5151#issuecomment-1066116927
> Thanks for the feedback. Not all TM4C devices have dual CAN: https://www.ti.com/lit/sg/spmt285e/spmt285e.pdf Ah I see; many of the TM4C123 parts have only one CAN MAC. So in that case, I recommend to add `select TIVA_HAVE_CAN1` individually to TM4C123AH6PM, TM4C123GH6ZRB, TM4C123GH6PZ, TM4C123GH6PGE, TM4C1294NCPDT, TM4C129XNCZAD, TM4C129ENCZAD, and TM4C129ENCPDT, *not* to ARCH_CHIP_TM4C. This way, if/when architectural support is added for other TM4C12x parts, we will be able to specify the correct number of CAN MACs for the chip. > Should the changes to arch/arm/src/tiva/Kconfig go in this PR or a different one? Up to you... feel free to either make the changes or let me know that you'd like to have this PR merged as-is. I'm okay with either one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
