xiaoxiang781216 commented on pull request #5729: URL: https://github.com/apache/incubator-nuttx/pull/5729#issuecomment-1066289806
> I applied all suggestions and squashed the commits. > > > Yes, I agree that the tab/space usage should be consistent, either tab or space is fine, but not mix. Since many assemble files under other arch use tab, if you decide switch to space, please change all of them, thanks. > > Very few assembly files are consistent in their indentation. Xtensa ones are also very inconsistent, so fixing just a snippet feels pointless, besides we have no rule on what to use. > > Regarding changing tabs to spaces, that would be my preference too, but changing all of the assembly fils in tree is out of the scope of this PR. Agree, it's enough to keep the consistent style in this PR. The tab/space conversion need a new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
