masayuki2009 commented on a change in pull request #5752:
URL: https://github.com/apache/incubator-nuttx/pull/5752#discussion_r827898406
##########
File path: arch/arm/src/cxd56xx/cxd56_serial.c
##########
@@ -1001,9 +1001,13 @@ static void up_txint(FAR struct uart_dev_s *dev, bool
enable)
* interrupts disabled (note this may recurse).
*/
+# ifdef CONFIG_SMP
spin_unlock_irqrestore(&priv->lock, flags);
Review comment:
@pkarashchenko
If we find such corruption in SMP mode in the future, I would revert the
changes. (i.e. use critical section API instead of spinlock API for
cxd56_serial.c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
