xiaoxiang781216 commented on a change in pull request #5758:
URL: https://github.com/apache/incubator-nuttx/pull/5758#discussion_r828131532
##########
File path: arch/risc-v/src/mpfs/mpfs_irq.c
##########
@@ -107,7 +107,7 @@ void up_irqinitialize(void)
irq_attach(RISCV_IRQ_ECALLM, riscv_swint, NULL);
-#ifdef CONFIG_BUILD_PROTECTED
+#if !defined (CONFIG_BUILD_FLAT)
Review comment:
ditto
##########
File path: arch/risc-v/src/mpfs/Make.defs
##########
@@ -62,14 +62,23 @@ ifeq ($(CONFIG_MPFS_DMA),y)
CHIP_CSRCS += mpfs_dma.c
endif
-ifeq ($(CONFIG_BUILD_PROTECTED),y)
-CMN_CSRCS += riscv_task_start.c
-CMN_CSRCS += riscv_pthread_start.c
-CMN_CSRCS += riscv_signal_dispatch.c
+# Flag to enable certain modules for non-flat builds (PROTECTED/KERNEL)
+__MPFS_BUILD_NONFLAT =
+ifeq ($(CONFIG_BUILD_PROTECTED),y)
Review comment:
why not check ifneq ($(CONFIG_BUILD_FLAT),y) and remove
__MPFS_BUILD_NONFLAT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
