gustavonihei commented on a change in pull request #5827:
URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r833224894



##########
File path: arch/xtensa/src/esp32s2/Kconfig
##########
@@ -738,50 +749,6 @@ config ESP32S2_SPIRAM_IGNORE_NOTFOUND
                panic. If this is enabled, booting will complete but no PSRAM
                will be available.
 
-config ESP32S2_SPIRAM_2T_MODE
-       bool "Enable SPI PSRAM 2T mode"
-       depends on ESP32S2_SPIRAM
-       default "n"
-       ---help---
-               Enable this option to fix single bit errors inside 64Mbit PSRAM.
-               Some 64Mbit PSRAM chips have a hardware issue in the RAM which
-               causes bit errors at multiple fixed bit positions.
-               Note: If this option is enabled, the 64Mbit PSRAM chip will 
appear
-               to be 32Mbit in size.
-               Applications will not be affected unless the use the esp_himem
-               APIs, which are not supported in 2T mode.
-
-config ESP32S2_SPIRAM_BANKSWITCH_ENABLE
-       bool "Enable bank switching for >4MiB external RAM"
-       default y
-       ---help---
-               The ESP32S2 only supports 4MiB of external RAM in its address
-               space. The hardware does support larger memories, but these
-               have to be bank-switched in and out of this address space.
-               Enabling this allows you to reserve some MMU pages for this,
-               which allows the use of the esp_himem api to manage these
-               banks.
-               #Note that this is limited to 62 banks, as
-               #esp_spiram_writeback_cache needs some kind of mapping of
-               #some banks below that mark to work. We cannot at this
-               #moment guarantee this to exist when himem is enabled.
-               If spiram 2T mode is enabled, the size of 64Mbit psram will
-               be changed as 32Mbit, so himem will be unusable.
-
-config SPIRAM_BANKSWITCH_RESERVE
-       int "Amount of 32K pages to reserve for bank switching"
-       depends on ESP32S2_SPIRAM_BANKSWITCH_ENABLE
-       default 8
-       range 1 62
-       ---help---
-               Select the amount of banks reserved for bank switching. Note
-               that the amount of RAM allocatable with malloc will decrease
-               by 32K for each page reserved here.
-               Note that this reservation is only actually done if your
-               program actually uses the himem API. Without any himem
-               calls, the reservation is not done and the original amount
-               of memory will be available.
-
 endmenu #SPI RAM Config

Review comment:
       ```suggestion
   endmenu # SPI RAM Configuration
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to