xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r834612123



##########
File path: arch/risc-v/src/mpfs/Make.defs
##########
@@ -34,6 +34,14 @@ CMN_CSRCS += riscv_mdelay.c riscv_udelay.c 
riscv_copyfullstate.c
 CMN_CSRCS += riscv_idle.c riscv_tcbinfo.c riscv_getnewintctx.c
 CMN_CSRCS += riscv_cpuindex.c
 
+# If the NuttX kernel runs in S-mode
+
+ifeq ($(CONFIG_ARCH_USE_S_MODE),y)
+CMN_ASRCS += riscv_exception_macros.S riscv_machine_trap.S riscv_context.S

Review comment:
       why macros file isn't? it's just like C header file, only the caller 
need include it in .S file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to