yamt commented on pull request #5837: URL: https://github.com/apache/incubator-nuttx/pull/5837#issuecomment-1078658264
why do you replace arc4random_buf with getrandom? it seems awkward as one of the purpose of arc4random_buf (renamed from getrandom) was to avoid descrptor shortage and your getrandom is based on device files. ``` commit 859e1ce63a458b206623d8e41cd93588af61b62f Author: chao.an <anc...@xiaomi.com> Date: Sat Dec 12 14:16:07 2020 +0800 crypto/arc4random: rename getrandom to arc4random_buf Change-Id: I5c9f0c9acf5af71f01beceaf06ebe0a2c87676bc Signed-off-by: chao.an <anc...@xiaomi.com> ``` ``` commit dffb8a67e3e92500651db3eca516dbcfc275311a Author: Jussi Kivilinna <jussi.kivili...@haltian.com> Date: Thu Mar 30 07:38:37 2017 -0600 Add entropy pool and strong random number generator Entropy pool gathers environmental noise from device drivers, user-space, et c., and returns good random numbers, suitable for cryptographic use. Based on en tropy pool design from *BSDs and uses BLAKE2Xs algorithm for CSPRNG output. Patch also adds /dev/urandom support for using entropy pool RNG and new 'getrandom' system call for getting randomness without file-descriptor usage (thus avoiding file-descriptor exhaustion attacks). The 'getrandom' interface is similar as 'getentropy' and 'getrandom' available on OpenBSD and Linux respectively. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org