gustavonihei commented on a change in pull request #5897:
URL: https://github.com/apache/incubator-nuttx/pull/5897#discussion_r837500695
##########
File path: boards/risc-v/esp32c3/esp32c3-devkit/scripts/Make.defs
##########
@@ -41,8 +41,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing
endif
-ARCHCFLAGS = -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0
-ARCHCXXFLAGS = $(ARCHCFLAGS) -fno-exceptions -fcheck-new -fno-rtti
+ARCHCFLAGS += -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0
+ARCHCXXFLAGS += -fno-common -ffunction-sections -fdata-sections
-msmall-data-limit=0 -std=c++17
Review comment:
> [...], but since C is a subset of C++ (actually C++ is forced to
maintain compatibility with C)
I wouldn't bet on this. C and C++ parted ways some years ago. Even according
to [ISO CPP](https://isocpp.org/wiki/faq/c#is-c-a-subset), C++ is a superset of
C95, but both evolved on their own.
That's why I find hard to believe that the C++ frontend would accept every
flag for the C frontend.
But either way, I am usually not in favor of repeating ourselves, but in
this case I would prefer to repeat this small amount of flags for readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
