pussuw commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r837833387
##########
File path: arch/risc-v/src/common/riscv_swint.c
##########
@@ -179,6 +187,31 @@ int riscv_swint(int irq, void *context, void *arg)
riscv_registerdump(regs);
#endif
+ /* Handle the syscall */
+
+ regs = riscv_handle_syscall(regs);
+
+ /* Report what happened. That might difficult in the case of a context
+ * switch
+ */
+
+#ifdef CONFIG_DEBUG_SYSCALL_INFO
+ if (regs != CURRENT_REGS)
+ {
+ svcinfo("SWInt Return: Context switch!\n");
+ riscv_registerdump((const uintptr_t *)CURRENT_REGS);
+ }
+ else
+ {
+ svcinfo("SWInt Return: %d\n", regs[REG_A0]);
+ }
+#endif
+
+ return OK;
+}
+
+void *riscv_handle_syscall(uintptr_t *regs)
Review comment:
There were two points:
1. int riscv_swint(int irq, void *context, void *arg), irq is not active as
the call comes from thread, arg is not used / set, but then again irq is not
used either so it does not matter...
2. The handling of CURRENT_REGS, e.g. DEBUGASSERT(regs && regs ==
CURRENT_REGS); The function has 1 global variable so it is not really re-entrant
riscv_syscall_dispatch is re-entrant, always
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
