pussuw commented on a change in pull request #5919:
URL: https://github.com/apache/incubator-nuttx/pull/5919#discussion_r839499676



##########
File path: arch/Kconfig
##########
@@ -445,6 +445,7 @@ menuconfig ARCH_ADDRENV
        bool "Address environments"
        default n
        depends on ARCH_HAVE_ADDRENV
+       depends on ARCH_INTERRUPTSTACK != 0

Review comment:
       Yes but of course. The per process kernel stack requires an address 
environment. The intent of this commit was to add a guard against a 
misconfiguration as group_addrenv() cannot be executed on the user stack.
   
   But I guess we are left with these options:
   - Require the IRQ stack, which is not really true
   - Abandon this change, and hope future users of ARCH_ADDRENV realize that a 
neutral stack is needed
   - Something else ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to