xiaoxiang781216 commented on a change in pull request #5782:
URL: https://github.com/apache/incubator-nuttx/pull/5782#discussion_r841067490



##########
File path: arch/risc-v/src/common/riscv_exception_common.S
##########
@@ -69,48 +69,16 @@
 exception_common:
 
   addi       sp, sp, -XCPTCONTEXT_SIZE

Review comment:
       Here is my thought: It isn't a problem before since we just have one 
exception entry pointer, but now we have two(exception_common and 
riscv_dispatch_syscall), it's always good to make both share the code base as 
much as possible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to