xiaoxiang781216 commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-nuttx/pull/5966#discussion_r841188325
##########
File path: arch/arm/src/armv7-m/arm_tcbinfo.c
##########
@@ -112,6 +112,8 @@ const struct tcbinfo_s g_tcbinfo =
TCB_STATE_OFF,
TCB_PRI_OFF,
TCB_NAME_OFF,
+ TCB_REGS_OFF,
+ 17,
Review comment:
> Don't we have a macro for thus value?
This value is only used by gcc to get the basic register list which is
different from the full list.
> Also, I see that the `tcbinfo_s` struct has now another member, given the
initialization way, is `XCPTCONTEXT_REGS` in the right position here?
Adding this value is avoid to hardcode this information in nuttx-jlink.c:
https://github.com/apache/incubator-nuttx/pull/5966/files#diff-3ad0f365e6bae822bd903a59b51f56f84b12cde99627b13bca8870298e21269dL603-R638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
