xiaoxiang781216 commented on code in PR #5971:
URL: https://github.com/apache/incubator-nuttx/pull/5971#discussion_r841865583
##########
libs/libc/string/lib_memcmp.c:
##########
@@ -32,6 +32,7 @@
#ifndef CONFIG_LIBC_ARCH_MEMCMP
#undef memcmp /* See mm/README.txt */
+no_builtin("memcmp")
Review Comment:
It isn't good because this option has global scope and forbid the compiler
optimize the call site and find the wrong usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
