pkarashchenko commented on code in PR #5991: URL: https://github.com/apache/incubator-nuttx/pull/5991#discussion_r846778813
########## mm/mm_heap/mm_memalign.c: ########## @@ -106,13 +110,13 @@ FAR void *mm_memalign(FAR struct mm_heap_s *heap, size_t alignment, /* Then malloc that size */ - rawchunk = (size_t)mm_malloc(heap, allocsize); - if (rawchunk == 0) + rawchunk_ptr = mm_malloc(heap, allocsize); Review Comment: I still think that introduction of two local variables `ptr` and `rawchunk_ptr` is redundant and we can reuse `(FAR void *)` cast of existing `uintptr_t`, but that is minor and more related to code readability than to functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
