xiaoxiang781216 commented on code in PR #6029: URL: https://github.com/apache/incubator-nuttx/pull/6029#discussion_r848092294
########## include/time.h: ########## @@ -200,6 +200,8 @@ FAR struct tm *localtime_r(FAR const time_t *timep, FAR struct tm *result); size_t strftime(FAR char *s, size_t max, FAR const char *format, FAR const struct tm *tm) strftimelike(3); +FAR char *strptime(FAR const char *s, FAR const char *format, + FAR struct tm *tm); Review Comment: The convention of _XOPEN_SOURCE, GNU_SOURCE... is never used in nuttx before. It's better to convert the usage in one patch If this convention is our target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org