xiaoxiang781216 commented on PR #6092: URL: https://github.com/apache/incubator-nuttx/pull/6092#issuecomment-1101974461
> I will post some comments here: > > * `arch/arm/src/lpc17xx_40xx/lpc17_40_gpdma.c`: ` * enable bit. Any outstanding data in the FIFO�s is lost.` > * `arch/arm/src/lpc43xx/lpc43_timer.c`: `void *arg; /* Argument passed to the callback function */` -- please align with other members > * `arch/arm/src/nrf52/nrf52_rtc.c` -- review indentations in `struct nrf52_rtc_priv_s` > * `arch/arm/src/nrf52/nrf52_tim.c` -- review indentations in `struct nrf52_tim_priv_s` > * `static int hci_iqk_phy_efuse_valid(IQK_T *iqk_data)` -- remove extra spaces > * `arch/arm/src/sam34/sam_tc.c`: -- align `void *arg; /* Argument passed to the callback function */` with other members > All reported issues are fixed. > I definitely missed many places and even didn't finished compare. I still suggest to split this PR into smaller ones that will have to 200-300 files changed if possible. 1784 file changed PR seems to be unrealistic to review. At least for me. Done, I split two six patch(each one 200~300). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
