gustavonihei commented on code in PR #6146: URL: https://github.com/apache/incubator-nuttx/pull/6146#discussion_r857610616
########## boards/mips/pic32mx/pic32mx-starterkit/scripts/Make.defs: ########## @@ -49,7 +49,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing endif -ARCHCXXFLAGS = -fno-exceptions -fcheck-new Review Comment: `CXX_EXCEPTION` default value has not been changed, so I believe it doesn't trigger any update on defconfigs. NuttX boards all assume C++ Exceptions to be disabled by default and `CXX_EXCEPTION` is already disabled as well. ########## boards/mips/pic32mx/pic32mx-starterkit/scripts/Make.defs: ########## @@ -49,7 +49,6 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y) ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing endif -ARCHCXXFLAGS = -fno-exceptions -fcheck-new Review Comment: `CXX_EXCEPTION` default value has not been changed, so I believe it doesn't trigger any update on defconfigs. Most NuttX boards assume C++ Exceptions to be disabled by default and `CXX_EXCEPTION` is already disabled as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
