pkarashchenko commented on code in PR #6057: URL: https://github.com/apache/incubator-nuttx/pull/6057#discussion_r858491242
########## include/nuttx/net/ioctl.h: ########## @@ -112,8 +112,12 @@ /* SocketCAN ****************************************************************/ -#define SIOCGCANBITRATE _SIOC(0x002C) /* Get bitrate from a CAN controller */ -#define SIOCSCANBITRATE _SIOC(0x002D) /* Set bitrate of a CAN controller */ +#define SIOCGCANBITRATE _SIOC(0x002C) /* Get bitrate from a CAN controller */ +#define SIOCSCANBITRATE _SIOC(0x002D) /* Set bitrate of a CAN controller */ +#define SIOCACANEXTFILTER _SIOC(0x002E) /* Add hardware-level exteneded ID filter */ Review Comment: SocketCAN has the next: > CAN Controller Hardware Filters To reduce the interrupt load on deep embedded systems some CAN controllers support the filtering of CAN IDs or ranges of CAN IDs. These hardware filter capabilities vary from controller to controller and have to be identified as not feasible in a multi-user networking approach. The use of the very controller specific hardware filters could make sense in a very dedicated use-case, as a filter on driver level would affect all users in the multi-user system. The high efficient filter sets inside the PF_CAN core allow to set different multiple filters for each socket separately. Therefore the use of hardware filters goes to the category ‘handmade tuning on deep embedded systems’. The author is running a MPC603e @133MHz with four SJA1000 CAN controllers from 2002 under heavy bus load without any problems … So @JacobCrabill added an option that is "handmade tuning on deep embedded systems" from SocketCAN point of view -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
