xiaoxiang781216 commented on code in PR #6165: URL: https://github.com/apache/incubator-nuttx/pull/6165#discussion_r859864348
########## arch/arm/src/Makefile: ########## @@ -20,6 +20,7 @@ include $(TOPDIR)/Make.defs include chip/Make.defs +include common/Make.defs Review Comment: should we add armvx-y/Make.defs too? 1. armvx-y/Make.defs include common/Make.defs 2. chip's Make.defs include armvx-y/Make.defs It's not good to include common/Make.defs here since the chip is hard to replace the unwanted common file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
