maht commented on code in PR #6152: URL: https://github.com/apache/incubator-nuttx/pull/6152#discussion_r859979918
########## include/nuttx/lib/lib.h: ########## @@ -114,10 +114,12 @@ void lib_stream_release(FAR struct task_group_s *group); #ifdef CONFIG_STDIO_DISABLE_BUFFERING # define lib_sem_initialize(s) # define lib_take_semaphore(s) +# define lib_try_take_semaphore(s) Review Comment: yes, maybe keeping the name and the indirection level is of no value and probably the code will become more clear to people familiar with the POSIX naming. I will try to rename it in an extra commit of this draft (this way if desired, it can be collapsed easily into one single commit before making it a non-draft PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
