pkarashchenko commented on code in PR #6155: URL: https://github.com/apache/incubator-nuttx/pull/6155#discussion_r861502858
########## arch/arm/src/arm/Toolchain.defs: ########## @@ -51,20 +51,22 @@ endif # CROSSDEV The GNU toolchain triple (command prefix) # ARCHCPUFLAGS CPU-specific flags selecting the instruction set # FPU options, etc. -# MAXOPTIMIZATION The maximum optimization level that results in +# ARCHOPTIMIZATION The optimization level that results in # reliable code generation. # +ARCHOPTIMIZATION += -fno-strict-aliasing Review Comment: I see that usage of `-fno-strict-aliasing` was guarded by `ifneq ($(CONFIG_DEBUG_NOOPT),y)` but now it is always set. Just want to confirm that this is "as expected". ########## boards/xtensa/esp32s3/esp32s3-devkit/scripts/Make.defs: ########## @@ -28,10 +28,6 @@ ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s3.ld ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s3_rom.ld ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s3_peripherals.ld -ifneq ($(CONFIG_DEBUG_NOOPT),y) - ARCHOPTIMIZATION += $(MAXOPTIMIZATION) -fno-strict-aliasing -fno-strength-reduce Review Comment: Why `-fno-strength-reduce` is removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
