pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r870982380
########## include/sys/atexit.h: ########## @@ -0,0 +1,81 @@ +/**************************************************************************** + * include/sys/atexit.h Review Comment: Now that I think of it, maybe tls.h is good enough. That is the "re-entrancy" structure we use in NuttX right ? So semantically this stuff can go there. One issue is the naming, is it ok to put procedures that are not named "tls_xxx" into tls.h, or should I still make another header file for this. I see three options: 1. Move atexit.h to the root of /include, this is quite a common way to do it it seems 2. Move contents of atexit.h to tlsh. (but then the file has names with tls_ and atexit_ ) 3. Move atexit.h to include/nuttx (I think this would be best, because these functions are nuttx implementation specific) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
