[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6235: RISC-V: add C++ support to crt0

[GitBox]

pkarashchenko commented on code in PR #6235:
URL: https://github.com/apache/incubator-nuttx/pull/6235#discussion_r871816120


##########
arch/risc-v/src/common/crt0.c:
##########
@@ -88,6 +88,71 @@ static void sig_trampoline(void)
   );
 }
 
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+#if defined(__cplusplus)

Review Comment:
   do we expect to compile this file with CXX?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org