zhuyanlinzyl commented on code in PR #5928: URL: https://github.com/apache/incubator-nuttx/pull/5928#discussion_r873300165
########## include/nuttx/spinlock.h: ########## @@ -32,7 +32,7 @@ #include <nuttx/irq.h> -#ifndef CONFIG_SPINLOCK Review Comment: 1 We need to use up_testset in boadctl.c for LTP testcase, that will call to xtensa_testset. 2 Our xtensa chip not support sync instruction( S32C1L) in xtensa_testset.c, and will let to build break. 3 When enable `CONFIG_ARCH_HAVE_TESTSET` but not enable `CONFIG_SPINLOCK` , `struct spinlock_t *lock ` will not find defination. So , I think we need to used CONFIG_ARCH_HAVE_TESTSET instead of SPINLOCK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
